Make TCPOutput more robust to failures #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @buger it doesn't seem like the tests are running successfully on master at the moment (even without my change). Do you have any idea what's up? |
|
@wmoss looks like travis changed smth on their side, and not use |
|
Looks good to me, thanks! Pls also add log call wen you failed connect to replay server. Test runner fixed in master, feel free to merge latest master to your branch, and see if tests pass. |
This should allow for running a gor listener on a production box and bringing up and down the replay node without having to go restart the listener.
|
Rebased on top of your master and looks like the tests pass. Also, regarding the log line, I'm happy to add one to my new code, but there is already one in the |
|
@wmoss ah, i see. Then looks good to me 👍 |
buger
added a commit
that referenced
this pull request
Feb 23, 2015
Make TCPOutput more robust to failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for running a gor listener on a
production box and bringing up and down the replay
node without having to go restart the listener.